Skip to content

Conversation

ticki
Copy link
Contributor

@ticki ticki commented Jul 21, 2015

Just some small changes.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ticki
Copy link
Contributor Author

ticki commented Jul 21, 2015

Thank you, my fellow bot.


But it will let you write things that _do_ break some of the rules. Let’s go
over these three abilities in order.
You will also encounter the 'unsafe' keyword when writing bindings to foreign
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in graves, not apostraphes, see line 101 and 102 above

@steveklabnik
Copy link
Contributor

one tiny nit, otherwise r=me

@ticki
Copy link
Contributor Author

ticki commented Jul 21, 2015

Done.

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 21, 2015

📌 Commit cf1e078 has been approved by steveklabnik

@steveklabnik
Copy link
Contributor

Thank you!

@ticki
Copy link
Contributor Author

ticki commented Jul 21, 2015

Yes, you bots are so friendly.

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 21, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 22, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 22, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 22, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 22, 2015
@bors bors merged commit cf1e078 into rust-lang:master Jul 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants